Victor Font replied 1 year ago

That is mighty generous of you, my friend! Thank you for your contribution to the community.

William Kudrle replied 1 year ago

Wow! Thanks so much for your work on this! I have downloaded your version and am trying to use it now. I am getting the following error when I try to show the Build page for my Formidable Form.

[08-Jun-2023 17:45:55 UTC] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /var/www/demolabbook/wp-content/plugins/formidable/classes/helpers/FrmFieldsHelper.php:1881
Stack trace:
#0 /var/www/demolabbook/wp-content/plugins/formidable/classes/views/frm-forms/add_field_links.php(101): FrmFieldsHelper::show_add_field_buttons()
#1 /var/www/demolabbook/wp-content/plugins/formidable/classes/views/frm-forms/edit.php(21): require('...')
#2 /var/www/demolabbook/wp-content/plugins/formidable/classes/controllers/FrmFormsController.php(1138): require('...')
#3 /var/www/demolabbook/wp-content/plugins/formidable/classes/controllers/FrmFormsController.php(143): FrmFormsController::get_edit_vars()
#4 /var/www/demolabbook/wp-content/plugins/formidable/classes/controllers/FrmFormsController.php(1760): FrmFormsController::edit()
#5 /var/www/demolabbook/wp-includes/class-wp-hook.php(308): FrmFormsController::route()
#6 /var/www/demolabbook/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters()
#7 /var/www/demolabbook/wp-includes/plugin.php(517): WP_Hook->do_action()
#8 /var/www/demolabbook/wp-admin/admin.php(259): do_action()
#9 {main}
thrown in /var/www/demolabbook/wp-content/plugins/formidable/classes/helpers/FrmFieldsHelper.php on line 1881

When I comment out line 1881 of FrmFieldsHelper.php, then I get a bunch of errors about the icons displaying, but the Tables field icon does show up and is functional to a large extent from what I can tell.

I am pretty new to WP programming, but have been programming with PHP for quite a while. I will continue to look into this and see what I can find. Just wanted to give you a huge thank you for your work on this. This is going to be very helpful for my site. Really appreciate it.

Walter Jones replied 1 year ago

I’m not sure why that’s happening, did you copy and paste the support file into a code snippet as well? The one from the gist? It’s required to function properly.

William Kudrle replied 1 year ago

Yes, I installed the WP Code plugin (Lite version) and then copied code from the SUPPORT-FUNCTIONS.txt from the repo as a PHP Snippet and activated it and used the Auto Insert insert method and said to run everywhere. I tried deleting and re-installing the Formidable Plus plugin but seem to still get the same error. I haven't tried it yet in a simple installation without a lot of plugins, so that might be an issue. Tomorrow I should be able to try it with a simple WP install with just the minimal plugins and will post here what happens.

Walter Jones replied 1 year ago

Make sure you have Formidable Form and Formidable Forms Pro installed and uptodate. Also, I have always had more success with Code Snipetts Plugin

William Kudrle replied 1 year ago

I was able to spend some time in the debugger and came up with a simple solution that seemed to fix my issue. It was a change in the code in the ZIP file contents. In the classes/helpers/FrmPlusFieldsHelper.php I changed the add_plus_fields($fields) function to use an array for the $fields values.

$fields['table'] = array('name' => "Table", 'icon' => "frm_icon frm_upload_icon", 'message' => 'Add configurable table field to form');

I created a pull request on your repo, but this is the first WordPress PR that I have done, so hopefully it will work OK.

I am not familiar enough with WP to know if this could have been done more easily in the SUPPORT-FUNCTIONS.txt file. Please let me know if you have any suggestions for how to improve this. Thanks again for your contribution. It is very greatly appreciated.